Api integration on Homepage #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by:GuilhermeRCost<[email protected]>
Co-authored-by:VCOliver<[email protected]>
…FeudoVerdePantano/GameReview-Front into Paginas-login-cadastro-senha
AlineLermen
requested changes
Apr 11, 2022
|
Other than that, LGTM |
AlineLermen
requested changes
Apr 16, 2022
There was a problem hiding this comment.
When running, got the errors:
Module not found: Error: Can't resolve './Normilaze.css' in '/home/aline/Documentos/DS/projeto/gamereview/src'
Module not found: Error: Can't resolve './Pages/Homepage' in '/home/aline/Documentos/DS/projeto/gamereview/src'
For the first one, the file just doesn't exist
For the second one, I believe it's because of the upper/lower case in "homepage" folder (Homepage)
AlineLermen
approved these changes
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Homepage now get the games using the external game API
Features:
Games images and titles are being showed at the homepage using the API
Minor otimizations to the requests
Resolve Issue DS-FeudoVerdePantano/GameReview-Docs#3
Resolve Issue DS-FeudoVerdePantano/GameReview-Docs#27
Resolve Issue DS-FeudoVerdePantano/GameReview-Docs#26
Coauthored by: Igor Penha @igorpenhaa, Guilherme Costa @GuilhermeRCost, Lucas Gobbi @LucasBergholz and Victor Cruz @VCOliver